[Bf-committers] Code Quality Day - 6/Nov

[Julian Eisel]

Hi all,

I started work to refactor the Outliner architecture into a more manageable, testable, readable and safer design using C++.
https://developer.blender.org/D9499

This is a relatively low-hanging fruit as a first experiment on the process of moving to a better engineered, "modern C++" based design for our UI code. I’m quite happy with how it turned out, seems like a great quality improvement already.
And finally, it was something more fun than what I usually do on code quality days :)

Once merged, it’s also the first part using C++ in our general UI code.

Cheers!

----------------------------------------------------------------------
Julian Eisel - julian at blender.org - www.blender.org
Software Developer

> On 6. Nov 2020, at 20:31, Aaron Carlisle via Bf-committers <bf-committers at blender.org> wrote:
> 
> 
> Hi,
> 
> I worked on cleaning up the render module directory structure to match
> other modules.
> This included renaming files and creating a more flat directory layout
> (remove render/exten and combine render/intern/source and
> render/intern/include)
> 
> Have a nice day
> 
> On Fri, Nov 6, 2020 at 12:33 PM Sergey Sharybin via Bf-committers <
> bf-committers at blender.org> wrote:
> 
>> Hi,
>> 
>> Thought to give a quick update of what happened today.
>> 
>> - A lot of all-around cleanup From Campbell
>> - Jacques continued working on moving Blend I/O to IDType
>> - Sergey did various Clang-Tidy warnings
>> - Sybren looked into using Blender's C++ container types in Alembic/USD.
>> Turned out to be more tricky than it sounds. Moved to Clang-Tidy related
>> tasks.
>> - Sebastian Barschkis did general cleanup of fluid API
>> - Richard was working on solving ambiguity in frame variables naming in
>> sequencer.
>> 
>> One of the outcomes of Clang-Tidy tasks is that within the current version
>> of Clang-Tidy all readability and bugprone warnings on Linux are solved.
>> The new category of modernize warnings has been enabled! Myself, Sybren,
>> and Jacques handled some of the modernize warnings already.
>> 
>> I've also put some new ideas, currently under a text file:
>> https://developer.blender.org/P1756
>> Would be nice to talk about them with developers from modules and
>> either accept them officially or discard them.
>> 
>> Most likely I've missed someone's contribution. There were a lot of commits
>> happening, a lot of work which kept away from looking into mail.  Feel free
>> to send a followup here with your details.
>> 
>> On Thu, Nov 5, 2020 at 3:53 PM Sergey Sharybin <sergey.vfx at gmail.com>
>> wrote:
>> 
>>> Hi,
>>> 
>>> This Friday we have November's code quality day [1].
>>> 
>>> The current progress is nicely written up by Dalai in the blog post [2].
>>> 
>>> The full list of approved projects for the quality day is combined in a
>>> dedicated task [3].
>>> Smaller and isolated projects are to tackle Clang-Tidy [4]. We need to
>>> wrap those up and enable possibly Clang-Tidy by default for developers!
>>> 
>>> There are bigger impact projects I have in mind, but was preoccupied an
>>> entire week with other tasks and didn't have time to properly add them to
>>> the T73586. Suggest we all talk tomorrow morning and see which of the
>>> bigger projects and tasks we want to be tackled.
>>> 
>>> Everyone is welcome to help!
>>> 
>>> For feedback on what to do, code review, and everything else we should
>> use
>>> #blender-coders in blender.chat.
>>> 
>>> [1] - https://wiki.blender.org/wiki/Style_Guide/Code_Quality_Day
>>> [2] - https://code.blender.org/2020/11/code-quality-day/
>>> [3] - https://developer.blender.org/T73586
>>> [4] - https://developer.blender.org/T78535
>>> 
>>> Have fun tomorrow,
>>> -Sergey-
>>> 
>>> --
>>> With best regards, Sergey Sharybin
>>> 
>> 
>> 
>> --
>> With best regards, Sergey Sharybin
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> https://lists.blender.org/mailman/listinfo/bf-committers
>> 
> 
> 
> --
> Aaron Carlisle
> 
> Project administrator for the Blender 3D Documentation Project
> Email: carlisle.b3d at gmail.com
> Website: https://blendify.github.io
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> https://lists.blender.org/mailman/listinfo/bf-committers