[Bf-committers] Code proposal for new modifiers

[Christian Hubert]

Hi Sybren,


Thanks for your reply.

I've posted a diff for one of them only (randomize) as I prefer do things step by step for this first time. Here is the link of the diff https://developer.blender.org/D3195

I was unsure but I've set yourself as reviewer and me as suscriber (but I don't really know what "suscriber" means here).


Concerning your work on temp-modifier-rm-cddm. Yes, I've seen that and I will try to set future diffs from this branch. But I've encountered an issue with 2.8: it compiles but crashes at first run steps (information here https://devtalk.blender.org/t/accessing-to-2-8-branch/353/2). I've just "git checkout blender2.8" but don't know if it is enough (I don't know git... my bad...).

What I propose is to fix this issue before porting other things in the branch you mentioned (temp-modifier-rm-cddm), but I've no idea how to fix it for now.

Should I "git checkout temp-modifier-rm-cddm"? Simply and only that?


Kind regards,

Christian


-----Message d'origine-----
De : Sybren A. Stüvel <sybren at stuvel.eu> 
Envoyé : mardi 1 mai 2018 15:50
À : bf-committers at blender.org
Objet : Re: [Bf-committers] Code proposal for new modifiers

Hi Christian,


On 30-04-18 08:59, Christian Hubert wrote:
> I've coded two modifiers. The purpose at the beginning was to learn 
> about Blender code, but finally the result could be of some interest 
> as I've posted about it on right click select and the score seems to 
> be good 
> (https://blender.community/c/rightclickselect/85bbbc/fan-screw-variant-modifier and https://blender.community/c/rightclickselect/35bbbc/randomize-modifier-proposal).

Both modifiers look really nice :)

> So from that, I'm in pain to find my way: how to obtain an approval 
> about this dev? Should I simply post a diff here 
> https://developer.blender.org/differential/diff/create/ and "no more"?

Please post two diffs (one for each modifier, unless they share a lot of common code) there, and send us a link in a reply to this email.
Discussions about code are easier to do in the diff than here on the mailing list.

Please also be aware of the work I'm doing in the temp-modifier-rm-cddm branch (also see D3155), which changes the interface for modifier code.
If you have questions about this, don't hesitate to ask here too.

Kind regards,
-- 

Sybren A. Stüvel

https://stuvelfoto.nl/
https://stuvel.eu/