[Bf-codereview] Tiles: Map Range Node (issue 6850047)
sergey.vfx at gmail.com
sergey.vfx at gmail.com
Wed Nov 14 15:09:46 CET 2012
Hi,
From implementation ans usability point of view it's all fine. However,
not sure having bot Map Value and Map Range nodes makes much sense and
doesn't sound intuitive.
Couldn't we change Map Value and write do_versions for this?
https://codereview.appspot.com/6850047/diff/1/source/blender/compositor/operations/COM_MapRangeOperation.cpp
File source/blender/compositor/operations/COM_MapRangeOperation.cpp
(right):
https://codereview.appspot.com/6850047/diff/1/source/blender/compositor/operations/COM_MapRangeOperation.cpp#newcode25
source/blender/compositor/operations/COM_MapRangeOperation.cpp:25:
MapRangeOperation::MapRangeOperation() : NodeOperation()
Would think m_useClamp better be initialzied here
https://codereview.appspot.com/6850047/
More information about the Bf-codereview
mailing list