[Bf-codereview] Tiles: Map Range Node (issue 6850047)

[Jeroen Bakker]

Hi Dalai,

I won't be able to review this patch until christmas. Perhaps someone else
can do this.

Jeroen.

On Wed, Nov 14, 2012 at 4:40 PM, <dfelinto at gmail.com> wrote:

> Reviewers: bf-codereview_blender.org, jbkkavt,
>
> Description:
> This node allows the user to convert an input value range into a
> destination range.
>
> One important use case is to easily map the z channel from its original
> range in real world meters (i.e.: 0 - 150) to a more usable range of 0-1
> (or similar) for use as a matte for colorization or filtering
> operations.
>
> Currently there are two options to acchieve this
>
> a) through the use of the normalize node, however this node is not
> animation safe since the color values will jump whenever a close or far
> away object enters on frame
>
> b) through the use of the map value node which is based on scaling and
> offsetting of the original values. This is an unintuitive method that
> requires a large amount of trial and error
>
> Sample test file (after patch):
> http://www.pasteall.org/blend/**17478<http://www.pasteall.org/blend/17478>
>
> Screenshot:
> http://www.pasteall.org/pic/**40381 <http://www.pasteall.org/pic/40381>
>
> Patch by Daniel Salazar (idea, tests) and me (implementation).
>
> Please review this at https://codereview.appspot.**com/6850047/<https://codereview.appspot.com/6850047/>
>
> Affected files:
>   source/blender/blenkernel/BKE_**node.h
>   source/blender/blenkernel/**intern/node.c
>   source/blender/compositor/**CMakeLists.txt
>   source/blender/compositor/**intern/COM_Converter.cpp
>   source/blender/compositor/**nodes/COM_MapRangeNode.cpp
>   source/blender/compositor/**nodes/COM_MapRangeNode.h
>   source/blender/compositor/**operations/COM_**MapRangeOperation.cpp
>   source/blender/compositor/**operations/COM_**MapRangeOperation.h
>   source/blender/editors/space_**node/drawnode.c
>   source/blender/makesrna/RNA_**access.h
>   source/blender/makesrna/**intern/rna_nodetree.c
>   source/blender/makesrna/**intern/rna_nodetree_types.h
>   source/blender/nodes/**CMakeLists.txt
>   source/blender/nodes/NOD_**composite.h
>   source/blender/nodes/**composite/nodes/node_**composite_mapRange.c
>
>
>


-- 
Jeroen Bakker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.blender.org/pipermail/bf-codereview/attachments/20121114/303d73a2/attachment.htm