[Bf-codereview] Tiles: Map Range Node (issue 6850047)

lukas.toenne at gmail.com lukas.toenne at gmail.com
Wed Nov 14 15:40:26 CET 2012


LGTM except for the initialization issue Sergey already found.

Just a quick comment: in general i would discourage making a do_versions
for node types to "switch them over" to a different behavior. In this
case it may be simple, but my experience (image node, file output node)
is that this can become really really messy and hard to maintain later
on, because it can conflict with expected behavior and make impossible
corner cases.

I wouldn't mind having an extra node for this. The conversion between
MapValue and MapRange is simple with a bit of math, but i think a
destination range is more common than a scale factor.

It can also be done easily with a node group btw ;)

https://codereview.appspot.com/6850047/


More information about the Bf-codereview mailing list