[Bf-codereview] Normalize Node - Tile (issue 5576078)
Dalai Felinto
dfelinto at gmail.com
Tue Jan 31 09:02:03 CET 2012
I forgot to say, I didn't test the node.
Neither i ported the tests again zBuff limits.
That said I indeed forgot to initialize the min and max oops. I'll update
the patch later.
Dalai
On Jan 30, 2012 11:47 PM, <dfelinto at gmail.com> wrote:
> Reviewers: bf-codereview_blender.org, jbkkavt,
>
> Description:
> as discussed during IRC the normalize node for tile.
>
> The implementation is simple. Fancy alternatives to gather the minimum
> and maximum through recursive loop in the tiles proved inefficient
> (Jeroen Bakker's tests/words).
>
>
> Please review this at http://codereview.appspot.com/**5576078/<http://codereview.appspot.com/5576078/>
>
> Affected files:
> source/blender/compositor/**CMakeLists.txt
> source/blender/compositor/**intern/COM_Converter.cpp
> source/blender/compositor/**nodes/COM_NormalizeNode.cpp
> source/blender/compositor/**nodes/COM_NormalizeNode.h
> source/blender/compositor/**operations/COM_**NormalizeOperation.cpp
> source/blender/compositor/**operations/COM_**NormalizeOperation.h
> source/blender/compositor/**operations/COM_**TonemapOperation.cpp
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.blender.org/pipermail/bf-codereview/attachments/20120131/35f8725d/attachment.htm
More information about the Bf-codereview
mailing list