[Bf-codereview] Normalize Node - Tile (issue 5576078)

[jbkkavt at gmail.com]

Hi Dalai,

great work!, just some small things, poke me if you need to.

Jeroen


http://codereview.appspot.com/5576078/diff/1/source/blender/compositor/operations/COM_NormalizeOperation.cpp
File source/blender/compositor/operations/COM_NormalizeOperation.cpp
(right):

http://codereview.appspot.com/5576078/diff/1/source/blender/compositor/operations/COM_NormalizeOperation.cpp#newcode79
source/blender/compositor/operations/COM_NormalizeOperation.cpp:79:
float minv, maxv;
minv and maxv are not initialized with blenderminz and blendermaxz.

Original code is min = 1.0f + BLENDER_ZMAX, max = 1.0f-BLENDER_ZMAX

Crucial part for correct working of the normalize node.

http://codereview.appspot.com/5576078/diff/1/source/blender/compositor/operations/COM_NormalizeOperation.h
File source/blender/compositor/operations/COM_NormalizeOperation.h
(right):

http://codereview.appspot.com/5576078/diff/1/source/blender/compositor/operations/COM_NormalizeOperation.h#newcode31
source/blender/compositor/operations/COM_NormalizeOperation.h:31:
typedef struct MinMax {
Naming the struct MinMax can be faulty when in the future more of these
structs will be defined.

You can also use NodeTwoFloats struct in DNA_node_types.h with comments
how and when the x and y are used.

See what you like as best solution.

http://codereview.appspot.com/5576078/