<p>I forgot to say, I didn't test the node. </p>
<p>Neither i ported the tests again zBuff limits.</p>
<p>That said I indeed forgot to initialize the min and max oops. I'll update the patch later.</p>
<p>Dalai</p>
<div class="gmail_quote">On Jan 30, 2012 11:47 PM, <<a href="mailto:dfelinto@gmail.com">dfelinto@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Reviewers: <a href="http://bf-codereview_blender.org" target="_blank">bf-codereview_blender.org</a>, jbkkavt,<br>
<br>
Description:<br>
as discussed during IRC the normalize node for tile.<br>
<br>
The implementation is simple. Fancy alternatives to gather the minimum<br>
and maximum through recursive loop in the tiles proved inefficient<br>
(Jeroen Bakker's tests/words).<br>
<br>
<br>
Please review this at <a href="http://codereview.appspot.com/5576078/" target="_blank">http://codereview.appspot.com/<u></u>5576078/</a><br>
<br>
Affected files:<br>
source/blender/compositor/<u></u>CMakeLists.txt<br>
source/blender/compositor/<u></u>intern/COM_Converter.cpp<br>
source/blender/compositor/<u></u>nodes/COM_NormalizeNode.cpp<br>
source/blender/compositor/<u></u>nodes/COM_NormalizeNode.h<br>
source/blender/compositor/<u></u>operations/COM_<u></u>NormalizeOperation.cpp<br>
source/blender/compositor/<u></u>operations/COM_<u></u>NormalizeOperation.h<br>
source/blender/compositor/<u></u>operations/COM_<u></u>TonemapOperation.cpp<br>
<br>
<br>
</blockquote></div>