[Bf-codereview] Cucumber: World Scaling R/W + VideoTexture Constants (issue 5530080)
ideasman42 at gmail.com
ideasman42 at gmail.com
Mon Jan 16 09:29:35 CET 2012
+1, to commit once BLI math functions are used (should make this code a
lot more clear).
http://codereview.appspot.com/5530080/diff/1/source/gameengine/Ketsji/KX_GameObject.cpp
File source/gameengine/Ketsji/KX_GameObject.cpp (right):
http://codereview.appspot.com/5530080/diff/1/source/gameengine/Ketsji/KX_GameObject.cpp#newcode2202
source/gameengine/Ketsji/KX_GameObject.cpp:2202: KX_GameObject* self =
static_cast<KX_GameObject*>(self_v);
suggest use BLI math functions here, see mathutils_Matrix.c's decompose
function:
--- these especially
mat3_to_quat(quat, rot);
mat4_to_loc_rot_size(loc, rot, size, (float (*)[4])self->matrix);
http://codereview.appspot.com/5530080/diff/1/source/gameengine/Ketsji/KX_GameObject.cpp#newcode2245
source/gameengine/Ketsji/KX_GameObject.cpp:2245: KX_GameObject* self =
static_cast<KX_GameObject*>(self_v);
this func could also make use of BLI math
http://codereview.appspot.com/5530080/
More information about the Bf-codereview
mailing list