[Bf-codereview] Color Matte Node (issue 5530079)

dfelinto at gmail.com dfelinto at gmail.com
Thu Jan 12 19:54:37 CET 2012


fixed the mentioned issues.
committed on rev. 43330


http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/nodes/COM_ColorMatteNode.cpp
File source/blender/compositor/nodes/COM_ColorMatteNode.cpp (right):

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/nodes/COM_ColorMatteNode.cpp#newcode45
source/blender/compositor/nodes/COM_ColorMatteNode.cpp:45:
inputSocketKey->relinkConnections(operationRGBToHSV_Key->getInputSocket(0),
true, 0, graph);
ahh now I understand this. this is the editorNodeInputSocketIndex.
changed.

On 2012/01/12 14:16:37, jbkkavt wrote:

inputSocketKey->relinkConnections(operationRGBToHSV_Key->getInputSocket(0),
> true, 1, graph);

> Should be '1' not '0'

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/operations/COM_ColorMatteOperation.cpp
File source/blender/compositor/operations/COM_ColorMatteOperation.cpp
(right):

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/operations/COM_ColorMatteOperation.cpp#newcode54
source/blender/compositor/operations/COM_ColorMatteOperation.cpp:54:
float alpha;
copy+paste legacy. removed
On 2012/01/12 14:16:37, jbkkavt wrote:
> Can't see where this is used

http://codereview.appspot.com/5530079/


More information about the Bf-codereview mailing list