[Bf-codereview] YCC Distance Matte Node implementation (issue 6462050)

[Dalai Felinto]

Hi Jeroen,

Regarding the patch (attached since the codereview didn't work) this
brings back 2.49 original functionality.
aka it's important if we really want to go 100% backward compatible.
Though it's possible people don't use that node.

I will try to find time to write on bf-committers. Just been very busy
lately, but wanted that in (or out) before 2.64 is out.

Thanks,
Dalai

2012/8/15  <jbkkavt at gmail.com>:
> have some issues to view the patch (the review site does not work) I
> think you did an svn mv on two files.
>
> Not sure about the functionality (I am just not the subject expert),
> perhaps this could be better asked to bf-committers.
>
>
>
> http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/nodes/COM_DistanceMatteNode.cpp
> File source/blender/compositor/nodes/COM_DistanceMatteNode.cpp (right):
>
> http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/nodes/COM_DistanceMatteNode.cpp#newcode64
> source/blender/compositor/nodes/COM_DistanceMatteNode.cpp:64:
> addLink(graph, operationYCCMatte->getOutputSocket(),
> operation->getInputSocket(1));
> operationYCCImage, operationYCCMatte are created but not added to the
> graph [graph->addOperation]. This will defect the execution (no
> init/deinit will be executed for these operations
>
> http://codereview.appspot.com/6462050/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: distance.diff
Type: application/octet-stream
Size: 16145 bytes
Desc: not available
Url : http://lists.blender.org/pipermail/bf-codereview/attachments/20120815/e2352dd5/attachment.obj