[Bf-codereview] YCC Distance Matte Node implementation (issue 6462050)
jbkkavt at gmail.com
jbkkavt at gmail.com
Wed Aug 15 20:46:00 CEST 2012
have some issues to view the patch (the review site does not work) I
think you did an svn mv on two files.
Not sure about the functionality (I am just not the subject expert),
perhaps this could be better asked to bf-committers.
http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/nodes/COM_DistanceMatteNode.cpp
File source/blender/compositor/nodes/COM_DistanceMatteNode.cpp (right):
http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/nodes/COM_DistanceMatteNode.cpp#newcode64
source/blender/compositor/nodes/COM_DistanceMatteNode.cpp:64:
addLink(graph, operationYCCMatte->getOutputSocket(),
operation->getInputSocket(1));
operationYCCImage, operationYCCMatte are created but not added to the
graph [graph->addOperation]. This will defect the execution (no
init/deinit will be executed for these operations
http://codereview.appspot.com/6462050/
More information about the Bf-codereview
mailing list