[Bf-codereview] YCC Distance Matte Node implementation (issue 6462050)

[jbkkavt at gmail.com]

Ok, just reviewed the last part of it. Don't think we can commit without
discussing this as this patch solves a bug and does not change
functionality. Sorry for the misunderstanding...

It seems that the calculateDistance method is not defined protected and
virtual.

With these adjustments it is ok to commit.
  * make calculateDistance protected virtual
  * remove execute pixel from subclass (when it is exactly the same)
  * add conversion operations to executionsystem



http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operations/COM_DistanceRGBMatteOperation.h
File
source/blender/compositor/operations/COM_DistanceRGBMatteOperation.h
(right):

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operations/COM_DistanceRGBMatteOperation.h#newcode37
source/blender/compositor/operations/COM_DistanceRGBMatteOperation.h:37:
+	float calculateDistance(float key[4], float image[4]);
Define this function protected virtual,
and only implement the execute pixel in the DistanceRGB matte, when it
is exact the same.

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operations/COM_DistanceYCCMatteOperation.cpp
File
source/blender/compositor/operations/COM_DistanceYCCMatteOperation.cpp
(right):

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operations/COM_DistanceYCCMatteOperation.cpp#newcode37
source/blender/compositor/operations/COM_DistanceYCCMatteOperation.cpp:37:
{
Remove this method as it is the same as the base class

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operations/COM_DistanceYCCMatteOperation.h
File
source/blender/compositor/operations/COM_DistanceYCCMatteOperation.h
(right):

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operations/COM_DistanceYCCMatteOperation.h#newcode33
source/blender/compositor/operations/COM_DistanceYCCMatteOperation.h:33:
private:
make this protected to use the definition in the base class

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operations/COM_DistanceYCCMatteOperation.h#newcode46
source/blender/compositor/operations/COM_DistanceYCCMatteOperation.h:46:

Remove the execute pixel as it is the same in the base class

http://codereview.appspot.com/6462050/