[Bf-codereview] Fisheye Panorama for Cycles (issue 6111052)

brechtvanlommel at gmail.com brechtvanlommel at gmail.com
Wed Apr 25 10:38:40 CEST 2012


Looks good, but there's still a bunch of code missing for adding
panorama as a proper camera type. It needs a version patch, changes in
blender internal, maybe 3d view drawing and any place that checks camera
type, and removal of the old use_panorama.


http://codereview.appspot.com/6111052/diff/1/intern/cycles/kernel/kernel_camera.h
File intern/cycles/kernel/kernel_camera.h (right):

http://codereview.appspot.com/6111052/diff/1/intern/cycles/kernel/kernel_camera.h#newcode96
intern/cycles/kernel/kernel_camera.h:96: float3 Pcamera =
transform_perspective(&rastertocamera, make_float3(raster_x, raster_y,
kernel_data.cam.panorama_fov));
Orthographic camera code should not be modified.

http://codereview.appspot.com/6111052/diff/1/intern/cycles/kernel/kernel_camera.h#newcode153
intern/cycles/kernel/kernel_camera.h:153: ray->dD.dx =
normalize(transform_direction(&cameratoworld,
equirectangular_to_direction(Pcamera.x, Pcamera.y))) - ray->D;
This also needs the if/else for the camera type.

http://codereview.appspot.com/6111052/


More information about the Bf-codereview mailing list