[Bf-codereview] Blender Dynamic Paint (soc-2011-carrot) (issue 5189041)

[g.ulairi at gmail.com]

Didn't notice something fatal. But as i told, a asked Brecht to check
render-related stuff. And probably he'll suggest something nicer for
that subframe updated.. Apart this thins, don't see any real issues.


http://codereview.appspot.com/5189041/diff/7001/source/blender/blenkernel/BKE_dynamicpaint.h
File source/blender/blenkernel/BKE_dynamicpaint.h (right):

http://codereview.appspot.com/5189041/diff/7001/source/blender/blenkernel/BKE_dynamicpaint.h#newcode28
source/blender/blenkernel/BKE_dynamicpaint.h:28: struct PaintAdjData
*adj_data; /* adjacency data for current surface */
Not sure, but probably some compilers can generate warning/error here.
Better to add "struct PaintAdjData;" to the beginning of this file (like
struct bContext and so)

http://codereview.appspot.com/5189041/diff/7001/source/blender/blenkernel/intern/dynamicpaint.c
File source/blender/blenkernel/intern/dynamicpaint.c (right):

http://codereview.appspot.com/5189041/diff/7001/source/blender/blenkernel/intern/dynamicpaint.c#newcode2537
source/blender/blenkernel/intern/dynamicpaint.c:2537: #if 0
In fact, if it's useful for debuggning this can be replaced with if (G.f
& G_DEBUG). Just a note :)

http://codereview.appspot.com/5189041/diff/7001/source/blender/blenkernel/intern/dynamicpaint.c#newcode5121
source/blender/blenkernel/intern/dynamicpaint.c:5121: if(md && md->mode
& (eModifierMode_Realtime | eModifierMode_Render))
Not sure, but does it mean modifier would be applied during viewport
playback when realtime apply is disabled but apply during render is
allowed?

http://codereview.appspot.com/5189041/diff/7001/source/blender/blenloader/intern/readfile.c
File source/blender/blenloader/intern/readfile.c (right):

http://codereview.appspot.com/5189041/diff/7001/source/blender/blenloader/intern/readfile.c#newcode4132
source/blender/blenloader/intern/readfile.c:4132: if (pmd->brush) {
Isn't it a duplicated check?

http://codereview.appspot.com/5189041/