[Bf-codereview] Camera tracking integration (issue 5285047)

[g.ulairi at gmail.com]

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/constraint.c
File source/blender/blenkernel/intern/constraint.c (right):

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/constraint.c#newcode3938
source/blender/blenkernel/intern/constraint.c:3938: /* -----------
Follow Track ------------- */
"Reconstruction" is libmv-side term, for artists "Solve" or "Solution"
is more familiar. And "Follow Track" does nothing with
solving/reconstruciton -- track is a 2d moving point on the footage, it
exists even if you don't want to solve something. Probably it can be
"Follow Motion Track" or something like this. Got no idea how "Camera
Solver" can be renamed in convenient for artists way.

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/constraint.c#newcode4021
source/blender/blenkernel/intern/constraint.c:4021: /* calculate lens
and sensor size depends on object type */
Yes, think this can be moved to function which will be shared with
object_camera_matrix.

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/object.c
File source/blender/blenkernel/intern/object.c (right):

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/object.c#newcode2196
source/blender/blenkernel/intern/object.c:2196: void
where_is_object_mat(Scene *scene, Object *ob, float obmat[4][4])
Yes, as comment for this function tells, it was intentional. This kind
of stuff is needed because motion-tracking stuff like bundles are
calculated in camera space. But in "original" camera space -- before
applying camera solver constraint, so when you move camera you see
bundles following the camera, but when start animation bundles stay
"stable" and only camera moves. In fact, i need function which will
calculate camera matrix without camera solver constraint. But can't see
any real usecase when camera which is used for solving has got other
constraints, so imo it's almost fine.

http://codereview.appspot.com/5285047/