[Bf-codereview] Camera tracking integration (issue 5285047)

[brechtvanlommel at gmail.com]

Just a few comments to get start, it's a big patch, will have to do this
in a few steps.


http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/constraint.c
File source/blender/blenkernel/intern/constraint.c (right):

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/constraint.c#newcode3938
source/blender/blenkernel/intern/constraint.c:3938: /* -----------
Follow Track ------------- */
The names of these constraints don't indicate clearly to me that they
are related to the tracker. Especially Follow Track / Follow Path is a
quite similar. Just a suggestion, maybe they could be called Follow
Reconstruction and Camera Reconstruction?

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/constraint.c#newcode4021
source/blender/blenkernel/intern/constraint.c:4021: /* calculate lens
and sensor size depends on object type */
Can the code here be refactored such that it shares this with
object_camera_matrix()?

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/object.c
File source/blender/blenkernel/intern/object.c (right):

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/object.c#newcode2196
source/blender/blenkernel/intern/object.c:2196: void
where_is_object_mat(Scene *scene, Object *ob, float obmat[4][4])
This function gives the object matrix without constraints, is that
intentional?

http://codereview.appspot.com/5285047/