[Bf-codereview] Blender Dynamic Paint (soc-2011-carrot) (issue 5189041)

[miikah88 at gmail.com]

Some replies to comments.


http://codereview.appspot.com/5189041/diff/7001/source/blender/blenkernel/intern/dynamicpaint.c
File source/blender/blenkernel/intern/dynamicpaint.c (right):

http://codereview.appspot.com/5189041/diff/7001/source/blender/blenkernel/intern/dynamicpaint.c#newcode2537
source/blender/blenkernel/intern/dynamicpaint.c:2537: #if 0
On 2011/10/19 16:55:34, nazgul wrote:
> In fact, if it's useful for debuggning this can be replaced with if
(G.f &
> G_DEBUG). Just a note :)
This is only useful when debugging UV surface generation code, so no
point enabling it for general debug. However it's useful enough to keep
here as #if 0 imo. :)

http://codereview.appspot.com/5189041/diff/7001/source/blender/blenkernel/intern/dynamicpaint.c#newcode5121
source/blender/blenkernel/intern/dynamicpaint.c:5121: if(md && md->mode
& (eModifierMode_Realtime | eModifierMode_Render))
On 2011/10/19 16:55:34, nazgul wrote:
> Not sure, but does it mean modifier would be applied during viewport
playback
> when realtime apply is disabled but apply during render is allowed?
You tell me. I'm not experienced enough in Blender's way of handling
simultaneous rendering/viewport usage to judge that. :x

Anyway, this part is quite much copied from smoke simulator (smoke.c) so
I assume it's ok.

http://codereview.appspot.com/5189041/diff/7001/source/blender/blenloader/intern/readfile.c
File source/blender/blenloader/intern/readfile.c (right):

http://codereview.appspot.com/5189041/diff/7001/source/blender/blenloader/intern/readfile.c#newcode4132
source/blender/blenloader/intern/readfile.c:4132: if (pmd->brush) {
On 2011/10/19 16:55:34, nazgul wrote:
> Isn't it a duplicated check?
Haha, dunno how I have missed that!

http://codereview.appspot.com/5189041/