[Bf-codereview] Node changes from Particles Branch (issue4476050)
brechtvanlommel at gmail.com
brechtvanlommel at gmail.com
Tue May 10 18:06:25 CEST 2011
Also reviewed node.c now, not much to comment.
http://codereview.appspot.com/4476050/diff/16001/source/blender/blenkernel/intern/node.c
File source/blender/blenkernel/intern/node.c (right):
http://codereview.appspot.com/4476050/diff/16001/source/blender/blenkernel/intern/node.c#newcode74
source/blender/blenkernel/intern/node.c:74: #include
"intern/node_socket.h"
The functions used here should be in a public header for the nodes
module, e.g. NOD_nodes.h, going into intern like that is not a good
precedent.
http://codereview.appspot.com/4476050/diff/16001/source/blender/blenkernel/intern/node.c#newcode1546
source/blender/blenkernel/intern/node.c:1546: #if 0
Seems this code can be removed.
http://codereview.appspot.com/4476050/
More information about the Bf-codereview
mailing list