[Bf-codereview] Node changes from Particles Branch (issue4476050)

lukas.toenne at googlemail.com lukas.toenne at googlemail.com
Tue May 10 13:21:50 CEST 2011


http://codereview.appspot.com/4476050/diff/16001/source/blender/makesdna/DNA_node_types.h
File source/blender/makesdna/DNA_node_types.h (right):

http://codereview.appspot.com/4476050/diff/16001/source/blender/makesdna/DNA_node_types.h#newcode314
source/blender/makesdna/DNA_node_types.h:314: #define
SOCK_SUBTYPE_XYZ			12
On 2011/05/09 11:15:24, brechtvl wrote:
> I don't think there is much point in duplicating these from RNA, it's
just more
> work to keep them in sync this way. A comment in RNA_types.h about
these values
> being written to file should be ok (I should have been more clear in
my earlier
> comment).

Ok, replaced this with PropertySubType values again and added a warning
in RNA_types.h.

http://codereview.appspot.com/4476050/


More information about the Bf-codereview mailing list