[Bf-codereview] Use DerivedMesh instead of Mesh in COLLADA GeometryExporter (issue4387052)

Nathan Letwory nathan.letwory at gmail.com
Fri Jun 17 11:46:25 CEST 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17.6.2011 11:09, pelle.johnsen at gmail.com wrote:
> On 2011/06/17 07:36:12, dBugSlayer wrote:
>> What are we going to do about all these changes? So far, I'm working
> with your
>> patch and the changes I got from official.address243. The changes I'm
> making are
>> been done on top of them, but I'm not sure if we're merging all them
> in one
>> entry here in codereview or if we should keep them separate.
> 
> 
> Been a bit concerned about this too. It's quite a large patch by now (at
> least for a noob blender dev as me). If there is a good way to split it
> up in smaller pieces, I think that would be best, but there are probably
> a lot of dependencies that makes it difficult.

It would indeed be nice to have these as smaller patches, but as Pelle
already mentions, the dependencies for the different parts make that
very hard. I think that what could be separated pretty easily is the
"export selection" part. If you guys could give that a shot, we could
have these two separate things reviewed in a faster pace and applied too
(at least the "export selection" would be nice to have this/next week in
trunk).

/Nathan

> 
> http://codereview.appspot.com/4387052/


- -- 
Nathan Letwory
Letwory Interactive | Studio Lumikuu
http://www.letworyinteractive.com | http://www.lumikuu.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJN+yJxAAoJEKtfN7KsE0TtcnkH+wcc3Oi+X4OBxMYVDhWJjEiy
HgSh9BBbae1gCLfQXIua88QjIP9lApoi6crxR7lqmSm15wT1MM6YM8wlc+vH/I2F
ER5LDTqeNS7GFBMFIdbo26QNWcWHc7zsGjFoh+ynuE57G01xeaPkr/4ojrR03i/q
1KRkUl56RsifHk/7iy61jk/TSlebLjgVnQDY20/aLhodJSzhYAbxok1QZTFw208z
G+tKJKdpBZxNHBuFGEcP3/E+alojlUwG1+EFKrB2g/vZCW1Gldd8UogqTpeS3izM
oVNth943eGfSXkqhX/4eC+B4OIWS7+Vr3rfpo3HNxhOfVDsqQW0/Lb8jo4CJM7k=
=eI/x
-----END PGP SIGNATURE-----


More information about the Bf-codereview mailing list