[Bf-blender-cvs] [44e530e1b10] master: Geometry Nodes: fix face corner to edge attribute interpolation

Jacques Lucke noreply at git.blender.org
Thu Jul 14 10:35:36 CEST 2022


Commit: 44e530e1b107fd0d91f472f9a58642ab59fd5422
Author: Jacques Lucke
Date:   Thu Jul 14 10:35:46 2022 +0200
Branches: master
https://developer.blender.org/rB44e530e1b107fd0d91f472f9a58642ab59fd5422

Geometry Nodes: fix face corner to edge attribute interpolation

Looks like this was wrong all the time.. Luckily, this conversion
is not very common.

Found when testing D15274.

===================================================================

M	source/blender/blenkernel/intern/geometry_component_mesh.cc

===================================================================

diff --git a/source/blender/blenkernel/intern/geometry_component_mesh.cc b/source/blender/blenkernel/intern/geometry_component_mesh.cc
index cf6681a69be..83bf2a5d27b 100644
--- a/source/blender/blenkernel/intern/geometry_component_mesh.cc
+++ b/source/blender/blenkernel/intern/geometry_component_mesh.cc
@@ -298,12 +298,14 @@ static void adapt_mesh_domain_corner_to_edge_impl(const Mesh &mesh,
     const MPoly &poly = mesh.mpoly[poly_index];
 
     /* For every edge, mix values from the two adjacent corners (the current and next corner). */
-    for (const int loop_index : IndexRange(poly.loopstart, poly.totloop)) {
-      const int loop_index_next = (loop_index + 1) % poly.totloop;
-      const MLoop &loop = mesh.mloop[loop_index];
+    for (const int i : IndexRange(poly.totloop)) {
+      const int next_i = (i + 1) % poly.totloop;
+      const int loop_i = poly.loopstart + i;
+      const int next_loop_i = poly.loopstart + next_i;
+      const MLoop &loop = mesh.mloop[loop_i];
       const int edge_index = loop.e;
-      mixer.mix_in(edge_index, old_values[loop_index]);
-      mixer.mix_in(edge_index, old_values[loop_index_next]);
+      mixer.mix_in(edge_index, old_values[loop_i]);
+      mixer.mix_in(edge_index, old_values[next_loop_i]);
     }
   }



More information about the Bf-blender-cvs mailing list