[Soc-2017-dev] Weekly Report #10 - Normal Editing Tools

[Rohan Rathi]

Hey,
I've removed the use of the flag (haven't removed the flag yet) and have
singled out most of the bugs in the code. Just some small UI changes
required and minor changes to the modifier and tools have been suggested,
not too hard to handle.
I'm beginning work on the user and code documentation on the wiki and
prepare for final evaluation.

On Mon, Aug 7, 2017 at 4:21 PM, Bastien Montagne <montagne29 at wanadoo.fr>
wrote:

> Hi Rohan,
>
> Agree polishing and bugfixing should be top priority now.
>
> Did quick review of code (nothing in-depth yet), overall looks very good.
> Noted the following points that you are still using
> BMO_OPTYPE_FLAG_INVALIDATE_CLNOR_ALL in addition to
> BMO_OPTYPE_FLAG_NORMALS_CALC, already said it, but imho this is needlessly
> verbose - I can’t imagine any case where you'd want to invalidate basic
> normals, while keeping clnors one valid? So imho,
> BMO_OPTYPE_FLAG_NORMALS_CALC should be redefined to also contain
> BMO_OPTYPE_FLAG_INVALIDATE_CLNOR_ALL, such that using the former
> automatically also triggers the later, without having to change any code
> for that.
>
> Cheers,
> Bastien
> Le 04/08/2017 à 20:12, Rohan Rathi a écrit :
>
> *Would really appreciate feedback on the tools added and the weighted
> normal modifier. Latest Windows release is included.*
>
> What I did this week:
> I've added some functionality to the weighted normals modifier. It had
> some serious bugs and glitches so  I've spent the majority of my time to
> refine and work on the features I've added. Most likely, the modifier will
> work completely fine now.
>
> Added the following:
> 1) Modifier now respects sharp edges similar to sharp edges with smooth
> shading.
> 2) Added vertex group support. Modifier will only affect vertex groups and
> leave all other loop data unchanged.
> 3) Add smooth/sharp flags as boolean weights. A check as well whether to
> use this function.
>
> What I plan on doing next week:
> With just over 2 weeks left for the project. I feel adding more tools is
> not a good option, not that I have anything important left to add. I'll go
> on to maintaining and documenting the code from next week onwards and
> prepare for final eval. There are some bugs and tasks that need attention
> so I'll put on focus on those.
>
> Latest Windows Release: https://drive.google.com/file/d/
> 0B9gCAchc4CLIV0lISFU5ZWptNXM/view?usp=sharing
>
> Links:
> My proposal: https://wiki.blender.org/index.php/User:RohanRathi
> /GSoC_2017/Proposal
> Documentation: https://docs.google.com/document/d/1YXOLuiYjU
> gaoxawtXqcRkET-G2M3MbASVop88lKaKbg/edit
> Git branch: https://developer.blender.org/diffusion/B/browse/soc
> -2017-normal-tools/
> Blender Artists Thread: https://blenderartists
> .org/forum/showthread.php?427746-GSoC-2017-Normal-Editing-Tools
>
> Thank You,
> Rohan Rathi
>
>
> _______________________________________________
> Soc-2017-dev mailing listSoc-2017-dev at blender.orghttps://lists.blender.org/mailman/listinfo/soc-2017-dev
>
>
>
> _______________________________________________
> Soc-2017-dev mailing list
> Soc-2017-dev at blender.org
> https://lists.blender.org/mailman/listinfo/soc-2017-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.blender.org/pipermail/soc-2017-dev/attachments/20170814/9a5bdf30/attachment.htm