[Soc-2006-dev] SoC weekly reporting

[Mazovka Dmitriy]

Well, no problem, I'll correct it and as soon as it will be ready
recommit. Decision to upload code was rather unexpected ;). So I
did not make the code fully fit rules. BTW thank you very much for
remarks. 

> .hpp -> .h
ok

> add GPL block to all .h
ok

> math.hpp 
except Vect3f class it contains necessary new functionality, I'll
redesign it and possibly remove Vect3f

> array.hpp ref.hpp
it is just copy & paste of 'my standart templates' I used to 
insert in every project :), will be removed

> tabs
I'll check


Regards,
Dmitriy

-----Original Message-----
From: Chris Want <cwant at ualberta.ca>
To: soc-2006-dev at blender.org
Date: Fri, 09 Jun 2006 08:15:38 -0600
Subject: Re: [Soc-2006-dev] SoC weekly reporting

> 
> 
> Also ... some of these .hpp's have no GPL block on
> them *AND* some use spaces for indentation rather
> than tabs.
> 
> I also see you have files math.cpp, array.hpp, etc..
> Blender already has a lot of code for doing math
> (perhaps too much) so you should see if you can
> reuse some of the existing code to get your math
> functions.
> 
> Regards,
> Chris
> 
> Chris Want wrote:
> > 
> > Hi Sionix,
> > 
> > Thanks for reminding about the weekly reports!
> > (I would have forgot).
> > 
> > One concern I have about your project, and this is
> > quite minor, is that you are using the naming
> > convention for your header files of *.hpp.
> > Everywhere else in the blender sources, whether
> > the code is C or C++, the convention we have been
> > using is *.h. Unless you absolutely need your files
> > to have the .hpp extension, could you please rename
> > these to have .h and recommit?
> > 
> > Thanks,
> > Chris
> > 
> > 
> > Mazovka Dmitriy wrote:
> > 
> >> Hello:)
> >>
> >> a) What you did in the previous week;
> >>
> >> 1. Added details of project to mediawiki.
> >> 2. Built test skygen, commit to cvs, maintained Makefiles.
> >> 3. Implemented draft UI
> >>
> >> b) What you plan to do in the following week;
> >>  
> >> 1. Complete wiki docs on Sky part.
> >> 2. Further development and tuning of Sky.
> >>
> >> c) Describe any issues you are having that may require extra attention.
> >>  
> >> 1. Color conversion (XYZ to RGB) possibly needs some tuning.
> >>
> >> _______________________________________________
> >> Soc-2006-dev mailing list
> >> Soc-2006-dev at blender.org
> >> http://projects.blender.org/mailman/listinfo/soc-2006-dev
> >>
> > 
> > _______________________________________________
> > Soc-2006-dev mailing list
> > Soc-2006-dev at blender.org
> > http://projects.blender.org/mailman/listinfo/soc-2006-dev
> > 
> 
> _______________________________________________
> Soc-2006-dev mailing list
> Soc-2006-dev at blender.org
> http://projects.blender.org/mailman/listinfo/soc-2006-dev
>