[Bf-gamedev] New 2DFilter system for BGE

[Dalai Felinto]

Pier,

Could you upload the next iteration of your patch to
developer.blender.org for the proper review? It's the best way to
receive feedback or even line-by-line code comments.

Thanks,
Dalai
--
blendernetwork.org/dalai-felinto
www.dalaifelinto.com


2015-01-07 5:46 GMT-02:00 pgi <pierluigi at tukano.it>:
> Thanks for the review.
>
> Sorry for the diff quality, I should have payed attention - I'm not
> confident yet with the various git parameters to produce patches.
>
> I will definitely get rid of the offscreen changes, the only things related
> to it are the two off-size parameters, they exist but are not used. In fact
> there is no offscreen anything (yet!).
>
> I'm pgi on #blendercoders
>
>
>
> On 07/01/2015 03:56, Daniel Stokes wrote:
>
> I took a quick look over your patch (sorry for the delay), and I like your
> idea of an alternative data structure for managing filters. I also
> appreciate that you actually payed attention to the existing encapsulation
> and made a GLSL concrete implementation of the abstract filter type. The
> diff was a little noisy with a lot of white space changes, and it would be
> best if you kept the refactor separate from the offscreen render changes
> (which I am guessing are not complete yet).
>
> Using a data class to reduce the number of arguments is fine, and is already
> done in the BGE in the physics code. In general, I find improving
> readability to rarely be bad practice.
>
> Do you ever go onto any of the Blender IRC channels? I use the nick Kupoman
> in #bgecoders and #blendercoders. I would love to have a more in depth
> conversation about your plans for the 2D filter system as I have a few
> thoughts on that part of the BGE myself.
>
> Regards,
> Daniel Stokes
>
> On Sat, Jan 3, 2015 at 9:41 AM, Jacob Merrill <blueprintrandom1 at gmail.com>
> wrote:
>>
>>
>> http://blenderartists.org/forum/showthread.php?358021-ogrender-blogre-something&p=2789237&viewfull=1#post2789237
>>
>> On Sat, Jan 3, 2015 at 9:40 AM, Jacob Merrill <blueprintrandom1 at gmail.com>
>> wrote:
>>>
>>> It looks like off screen rendering, and some cleanup from what I have
>>> read at BA.
>>>
>>> On Sat, Jan 3, 2015 at 9:33 AM, Daniel Stokes <kupomail at gmail.com> wrote:
>>>>
>>>> I will take a look at your diff later (on a phone right now). Could you
>>>> elaborate a bit on what your goals with the rewrite were?
>>>>
>>>> Regards,
>>>> Daniel Stokes
>>>>
>>>> On Jan 3, 2015 6:24 AM, "pgi" <pierluigi at tukano.it> wrote:
>>>>>
>>>>> Hello, happy new year and things.
>>>>>
>>>>> I rewrote the bge 2D filter system, there are a couple of minor things
>>>>> that I have to change (like naming conventions, formatting and so) and a few
>>>>> test I need to run before to have a real patch but I'd like someone to check
>>>>> how things are shaping because I made some design choices that might not be
>>>>> compatible with how blender is supposed to be.
>>>>> The new system is backward compatible. Well, it will be, I have to
>>>>> guess another two or three things before to be 100% sure about it.
>>>>>
>>>>> The attached diff contains the changes to the rasterizer package. There
>>>>> are maybe a couple of other minor changes in other parts of the code but
>>>>> they are not relevant.
>>>>>
>>>>> pgi
>>>>>
>>>>> _______________________________________________
>>>>> Bf-gamedev mailing list
>>>>> Bf-gamedev at blender.org
>>>>> http://lists.blender.org/mailman/listinfo/bf-gamedev
>>>>>
>>>>
>>>> _______________________________________________
>>>> Bf-gamedev mailing list
>>>> Bf-gamedev at blender.org
>>>> http://lists.blender.org/mailman/listinfo/bf-gamedev
>>>>
>>>
>>
>>
>> _______________________________________________
>> Bf-gamedev mailing list
>> Bf-gamedev at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-gamedev
>>
>
>
>
> _______________________________________________
> Bf-gamedev mailing list
> Bf-gamedev at blender.org
> http://lists.blender.org/mailman/listinfo/bf-gamedev
>
>
>
> _______________________________________________
> Bf-gamedev mailing list
> Bf-gamedev at blender.org
> http://lists.blender.org/mailman/listinfo/bf-gamedev
>