[Bf-committers] Clang-Tidy: Request for Feedback

[Ankit]

Consider `clang-tidy-diff.py` and `run-clang-tidy.py` [1] to cut down
time to run clang-tidy further. The latter is not incremental though.

Editor extensions based on clangd + LSP can show clang-tidy violations live as
the file is being edited. I've tried [2] and it's fine. There's one for VSCode too.

[1] https://github.com/llvm/llvm-project/tree/main/clang-tools-extra/clang-tidy/tool
[2] https://github.com/sublimelsp/LSP

Ankit (ankitm)

> On 04-Mar-2021, at 18:51, Bastien Montagne via Bf-committers <bf-committers at blender.org> wrote:
> 
> Hi, just my two cents, since I did not take part in this project in itself:
> 
>> So here are some questions to the developers:
>> 
>> - Do you have a strong feeling about leaving a .clang-tidy file as it is
>> now (where file modification requires manual re-compilation) ?
> I do not mind having to force clean rebuild once in a while if needed, no. Having this handled automatically would be nice of course, but does not look like a showstopper to me.
>> - Shall we enable it by default? Maybe for `make developer` ?
> 
> No, I don't think so, given the cost on building time. What I will likely do is having a dedicated build for that (like I have e.g. for lite builds for quick bisect, etc.), that I will run as part of clean-up & finalize process before committing, but not during on-going development.
> Indeed, enabling it on CI seems a very good idea though.
> 
> Cheers,
> Bastien
> 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> https://lists.blender.org/mailman/listinfo/bf-committers