[Bf-committers] potential buffer overflow in editors/space_file/file_ops.c

[Campbell Barton]

Thanks for the report, committed a different fix to master that avoid
using strncat
https://developer.blender.org/rB46dd04faed2c6718b3d1f9d7a72bd246c66909e1

On Wed, Mar 23, 2016 at 1:31 AM, Dave Plater <dplater.list at gmail.com> wrote:
> Hi,
> I maintain blender in openSUSE and I got this message from our build service
> building blender-2.77 for the first time:
> I: Statement might be overflowing a buffer in strncat. Common mistake:
> BAD: strncat(buffer,charptr,sizeof(buffer)) is wrong, it takes the left over
> size as 3rd argument
> GOOD: strncat(buffer,charptr,sizeof(buffer)-strlen(buffer)-1)
> E: blender bufferoverflowstrncat
> /home/abuild/rpmbuild/BUILD/blender-2.77/source/blender/editors/space_file/file_ops.c:1378:4
>
> I've attached a patch.
> Best regards
> Dave Plater
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>



-- 
- Campbell