[Bf-committers] Unlimited clay patch review

[Tom M]

On Mon, May 23, 2011 at 12:13 PM,  <raulf at info.upr.edu.cu> wrote:
> Thanks for the quick repply.
>
> I thougth someone has being able to compile it and post a build online ...
> didn't knew community don't have a build to test with.

There is  test build, but I'm not sure if it is built correct, it
gives really odd looking results.

> I will try to port the code to a recent build without BMesh, still the old
> EditMesh but just to make it more friendly.

Sounds good.

I just went through the entire patch, and it seems like almost half of
the code in the patch isn't actually used in the patch :)

Is there a reason so much stuff is commented out or not used anywhere?

Is it incomplete experiments or something else?

ie bere are all functions that are in the patch but are never used


# modifiers_isUClayEnabled -
# CDDM_from_editmesh_select -
# em_can_pbvh_draw -
# tensate -
# revised_ideal_length_relaxation -
# HC_relaxtion -
# select_edges_uclay -
# convert_to_triface_all -
# set_border_flag - optional function for all relaxtion functions
# smooth_vertex_editmesh -

# edDM_use_uclay_pbvh -

# BLI_pbvh_update_editmesh -
# make_editMeshDM -
# make_editmesh_arrays -
# load_editMesh_external -
# addedgeface_mesh_uclay -

# FastRayTri -
# circle_face_intersection -
# circle_eval -
# circle_segment_test -

# GPU_update_editmesh_buffers -
# GPU_build_editmesh_buffers -

LetterRip


> Cheers
> Raul
>
>
>> Hi raul,
>>
>> people are interested in it, but without it compiling against head,
>> people have difficulty playing with it (even compiling it against the
>> older version of blender that it uses is a bit of a pain - i think
>> only me and jms got it built).  Most users need features and fixes
>> from the most recent version of blender so unless they can apply it
>> against head, they won't be able to give much feedback.
>>
>> LetterRip
>>
>>
>>> due to the low feedback I'm getting from unlimitedClay for Blender ..
>>> are
>>> people still interested on it? I'm still here :(
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
>
>
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> - Participe en Universidad 2012, del 13 al 17 de febrero de 2012. Habana. Cuba. http://www.congresouniversidad.cu
>
> - Consulte la Enciclopedia Colaborativa Cubana. http://www.ecured.cu
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>