[Bf-committers] Modifier stack refactor

[André Pinto]

Hi Ben,

When working on my SoC project I had to look on modifiers and
definitely they needed a refactor like the one proposed :)

I wont say anything about when and in what branch it should be
committed as I don't really know about that.

But I took a look on your patch and I got a few points:

Where do headers related with modifiers go?
blender/source/blender/modifiers/MOD_modifiername.h?
In that case it seems you forgot to refactor headers like BKE_cloth.h,
BKE_softbody.h, BKE_subsurf.h

Also I remind you some modifiers were already "separated" from
modifier.c which is the case of:
cloth.c, softbody.c (maybe there are more)
and probably that code should also move to blender/source/blender/modifiers/
(Although I don't know blender code well.. and not sure if those files
are only modifier related)

At least thats my opinion (as a new developer in blender)

---
André

2008/6/23 Diego Hernan Borghetti <bdiego at gmail.com>:
> On Mon, 23 Jun 2008, GSR wrote:
>
>> Hi,
>> theeth at yahoo.com (2008-06-23 at 1453.33 -0700):
>>>> Or 2.47 bugfixes go to 2.47 branch and new code goes to
>>>> trunk.
>>>
>>> That's exactly what we DON'T want to do. That would be the best way to end up with a bug fixes in 2.47 but not in trunk (ie: later versions).
>>
>> I assumed the coder would had to knowledge to include "fixes" in new
>> code as well.
>
> But if we assumed too many things.. we finish with a really mess, so my
> opinion is no, only merge from trunk to 2.47.
>
> Also I know that if we split the code in different files it's hard apply
> the patch, but I don't have problem if Ben got the "OK" and start working in trunk.
>
>>
>> GSR
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
>
> --
>                        Diego
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>