[Bf-committers] Shape Action added in BGE

[Brecht Van Lommel]

Hi,

>There was a bit of conflict with the big update in the BGE after the
>merge from the Apricot branch. The conflicts were simple to resolved but
>I noticed something odd: BL_SkinDeformer::Apply() doesn't set the vertex
>normals anymore although they are computed in BL_SkinDeformer::Update().
>Shouldn't we have also this in BL_SkinDeformer::Apply() so be
>consistent:
>
>#ifdef __NLA_DEFNORMALS
>	
>tv->SetNormal(m_transnors[((*mvarray[i])[index])]); 
>#endif

Yes, they should perhaps be updated, but it doesn't work correct this way for flat faces, which is why I moved it out of Apply. How to get to the flat normal from Apply is not clear to me. Also, I committed a temporary fix for an issue in the last commit to Apricot, which is related to this. Apply was only being done for the first material bucket.

I don't really understand actually why there are separate Update and Apply functions .. why not do everything in Update? Do you know of any reason why it would need to do Apply in the drawing code? Otherwise I might just merge the code from Apply into Update.

Cheers,
Brecht.