[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [15716] branches/soc-2008-unclezeiv/source /blender/render/intern/source/shadeoutput.c: - readability enhancements for diffuse and specular shaders ( mostly used macros where possible, leading to

[Tom M]

Did you check that your optimizations are actually an optimization?
I'd be surprised for instance that precomputing a square is going to
gain you anything since the compiler probably already spots it and
does it for you.

LetterRip

On Wed, Jul 23, 2008 at 9:23 AM, Davide Vercelli
<davide.vercelli at gmail.com> wrote:
> Revision: 15716
>          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=15716
> Author:   unclezeiv
> Date:     2008-07-23 19:23:56 +0200 (Wed, 23 Jul 2008)
>
> Log Message:
> -----------
> - readability enhancements for diffuse and specular shaders (mostly used macros where possible, leading to clearer and more compact code)
> - a couple of slight optimizations (pre-computing parameters being used squared in many places, and anticipating a early out)