[Bf-committers] Patch #3760 Regression in 2.44

[Early Ehlinger]

Hi Shaul,

Sorry about that...

Here's the link to the patch that has a regression:

https://projects.blender.org/tracker/?group_id=9&atid=127&func=detail&aid=3760

I haven't gotten up to speed with Blender's svn support yet (hence my 
reference to building from CVS), so I don't know when the fix was 
removed yet, so I can't give you a before/after version number.  I've 
patched my local copy of 2.44's tarball - this bit from do_render in 
renderwin.c has changed:

            if(G.vd->lay & 0xFF000000) {
                G.scene->lay |= G.vd->lay;
                G.scene->r.scemode |= R_SINGLE_LAYER;
            }
            else G.scene->lay= G.vd->lay;

becomes:

        if ( G.vd ) {
            if(G.vd->lay & 0xFF000000) {
                G.scene->lay |= G.vd->lay;
                G.scene->r.scemode |= R_SINGLE_LAYER;
            }
            else G.scene->lay= G.vd->lay;
        }

This is identical to the change made for patch #3760, and in my initial 
testing it works.  However, as I said, I haven't gotten up to speed on 
building from svn yet, so it'll take some time to put together a patch.

-- Early Ehlinger, President, ResPower, Inc.


Shaul Kedem wrote:
> Hi,
>  As an outsider looking at this post I think you will get much more
> info by posting links to:
>  - your patch
>  - the code before and after in svn
>  - "cory's script from jan 06"
>
> just my .2 rupi
>
> Shaul
>
> On 7/8/07, Early Ehlinger <early at respower.com> wrote:
>   
>> Hi All,
>>
>> I just spent a couple of hours adding Blender_Trace statements (See
>> Patch 6161) to hunt down a crash in Blender 2.44 for a customer.  It
>> turns out that G.vd is NULL, and the check for G.vd being NULL was
>> removed sometime between Jan '06 and Blender 2.44.
>>
>> My guess is this happened when the following snip was moved from
>> BIF_do_render to do_render, but that's just a guess:
>>
>>             if(G.vd->lay & 0xFF000000) {
>>                 G.scene->lay |= G.vd->lay;
>>                 G.scene->r.scemode |= R_SINGLE_LAYER;
>>             }
>>             else G.scene->lay= G.vd->lay;
>>
>> Can anybody else confirm that this is a problem?  I'm waiting for my
>> customer to give permission to use his .blend file, which reproduces it
>> every time, but I suspect that Cory's script from Jan'06 will do the
>> trick, too.
>>
>> In the meantime, I'll see if I can get current CVS going and submit a
>> patch against it.
>>
>> -- ResPower Support
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
>>     
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>
>
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.blender.org/pipermail/bf-committers/attachments/20070708/673c7e2a/attachment.htm