[Bf-committers] Blender 2.43 RC1

[Giuseppe Ghibò]

Ton Roosendaal wrote:

> Hi,
> 
> First; snprintf() is not defined in all platforms, so it needs #ifdefs.
> 
> Second, why would you make this change? If you read the code there you
> can see it was implemented as intended.

Because it crashes immediately with buffer overflows
(though the code apparently seems correct). See my older mail.

Bye
Giuseppe.

> 
> -Ton-
> 
> On 8 Jan, 2007, at 9:36, Giuseppe Ghibò wrote:
> 
>> OK. I'll test. BTW, would be possible to commit also the one at:
>>
>> source/blender/blenloader/intern/writefile.c
>>
>> line 1853:
>>
>> sprintf(fg.subvstr, "%4d", BLENDER_SUBVERSION);
>>
>> with:
>>
>> snprintf(fg.subvstr, sizeof(fg.subvstr), "%4d", BLENDER_SUBVERSION);
>>
> 
> 
> 
> 
> --------------------------------------------------------------------------
> Ton Roosendaal  Blender Foundation ton at blender.org http://www.blender.org
> 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers