[Bf-committers] Blender 2.43 RC1
Ton Roosendaal
ton at blender.org
Mon Jan 8 14:07:06 CET 2007
Hi,
> Because it crashes immediately with buffer overflows
> (though the code apparently seems correct). See my older mail.
When does this crash?
It is not the nicest code in the world though... will commit something
else that works.
Note btw that using snprintf() will create a bug (adds trailing zero to
string). That was excactly the reason why I coded a 1 byte 'buffer
overflow' into a safe area.
-Ton-
>
> Bye
> Giuseppe.
>
>>
>> -Ton-
>>
>> On 8 Jan, 2007, at 9:36, Giuseppe Ghibò wrote:
>>
>>> OK. I'll test. BTW, would be possible to commit also the one at:
>>>
>>> source/blender/blenloader/intern/writefile.c
>>>
>>> line 1853:
>>>
>>> sprintf(fg.subvstr, "%4d", BLENDER_SUBVERSION);
>>>
>>> with:
>>>
>>> snprintf(fg.subvstr, sizeof(fg.subvstr), "%4d", BLENDER_SUBVERSION);
>>>
>>
>>
>>
>>
>> ----------------------------------------------------------------------
>> ----
>> Ton Roosendaal Blender Foundation ton at blender.org
>> http://www.blender.org
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at projects.blender.org
>> http://projects.blender.org/mailman/listinfo/bf-committers
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
>
>
>
------------------------------------------------------------------------
--
Ton Roosendaal Blender Foundation ton at blender.org
http://www.blender.org
More information about the Bf-committers
mailing list