[Bf-codereview] Compositor debug improvements (issue 13699043)
lukas.toenne at gmail.com
lukas.toenne at gmail.com
Fri Sep 13 15:29:31 CEST 2013
https://codereview.appspot.com/13699043/diff/1/source/blender/compositor/intern/COM_Debug.cpp
File source/blender/compositor/intern/COM_Debug.cpp (right):
https://codereview.appspot.com/13699043/diff/1/source/blender/compositor/intern/COM_Debug.cpp#newcode2
source/blender/compositor/intern/COM_Debug.cpp:2: * Copyright 2011,
Blender Foundation.
On 2013/09/13 13:18:41, sergey.vfx wrote:
> Sure about 2011, not 2013?
Lazy copying, fixed.
https://codereview.appspot.com/13699043/diff/1/source/blender/compositor/intern/COM_Debug.cpp#newcode402
source/blender/compositor/intern/COM_Debug.cpp:402: std::string
DebugInfo::node_name(NodeBase *node) { return ""; }
On 2013/09/13 13:18:41, sergey.vfx wrote:
> Afraid strict compiler flags would be unhappy with unused argument.
Would do
> this:
> std::string DebugInfo::node_name(NodeBase * /*node*/) { return ""; }
> Same applies to some few functions below as well.
Done.
https://codereview.appspot.com/13699043/diff/1/source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp
File source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp
(right):
https://codereview.appspot.com/13699043/diff/1/source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp#newcode40
source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp:40:
#include "MEM_guardedalloc.h"
On 2013/09/13 13:18:41, sergey.vfx wrote:
> Not sure why guardedalloc is needed? Is it to support guarded
allocating of
> DebugInfo?
Leftover include, removed.
https://codereview.appspot.com/13699043/
More information about the Bf-codereview
mailing list