[Bf-codereview] Compositor debug improvements (issue 13699043)
sergey.vfx at gmail.com
sergey.vfx at gmail.com
Fri Sep 13 15:18:41 CEST 2013
Apart from some really minor notes, LGTM.
https://codereview.appspot.com/13699043/diff/1/source/blender/compositor/intern/COM_Debug.cpp
File source/blender/compositor/intern/COM_Debug.cpp (right):
https://codereview.appspot.com/13699043/diff/1/source/blender/compositor/intern/COM_Debug.cpp#newcode2
source/blender/compositor/intern/COM_Debug.cpp:2: * Copyright 2011,
Blender Foundation.
Sure about 2011, not 2013?
https://codereview.appspot.com/13699043/diff/1/source/blender/compositor/intern/COM_Debug.cpp#newcode402
source/blender/compositor/intern/COM_Debug.cpp:402: std::string
DebugInfo::node_name(NodeBase *node) { return ""; }
Afraid strict compiler flags would be unhappy with unused argument.
Would do this:
std::string DebugInfo::node_name(NodeBase * /*node*/) { return ""; }
Same applies to some few functions below as well.
https://codereview.appspot.com/13699043/diff/1/source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp
File source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp
(right):
https://codereview.appspot.com/13699043/diff/1/source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp#newcode40
source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp:40:
#include "MEM_guardedalloc.h"
Not sure why guardedalloc is needed? Is it to support guarded allocating
of DebugInfo?
https://codereview.appspot.com/13699043/
More information about the Bf-codereview
mailing list