[Bf-codereview] Freestyle r54826 branch review (issue 7416049)

irieshinsuke at gmail.com irieshinsuke at gmail.com
Thu Mar 21 13:39:58 CET 2013


Added comments about two things:

1. UI glitch in property panel of 3d view
2. Inconsistency between factory settings and default values



https://codereview.appspot.com/7416049/diff/1/release/scripts/startup/bl_ui/space_view3d.py
File release/scripts/startup/bl_ui/space_view3d.py (right):

https://codereview.appspot.com/7416049/diff/1/release/scripts/startup/bl_ui/space_view3d.py#newcode2508
release/scripts/startup/bl_ui/space_view3d.py:2508: if context.scene and
bpy.app.build_options.freestyle:
Horizontally split row is too narrow to display labels "Freestyle Edge
Marks" and "Freestyle Face Marks", so both of them are truncated to
"Freestyle".

I think "col = layout.column()" should be inserted here to avoid this
glitch.

https://codereview.appspot.com/7416049/diff/1/source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp
File source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp
(right):

https://codereview.appspot.com/7416049/diff/1/source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp#newcode649
source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp:649:
{
Why these default values are different from the factory settings
(mode=FREESTYLE_CONTROL_EDITOR_MODE, crease_angle=134.43, etc.)?

https://codereview.appspot.com/7416049/


More information about the Bf-codereview mailing list