[Bf-codereview] Freestyle r54826 branch review (issue 7416049)
ideasman42 at gmail.com
ideasman42 at gmail.com
Tue Mar 19 01:41:57 CET 2013
Noticed 2 points...
- When using a script line style it defaults to contour.py I get this
error:
---
Traceback (most recent call last):
File "/contour.py", line 29, in <module>
Operators.select(AndUP1D(QuantitativeInvisibilityUP1D(0),
ContourUP1D()))
NameError: name 'AndUP1D' is not defined
---
Currently the absolute filepath to the script is used:
/src/blender_freestyle/release/scripts/freestyle/style_modules/contour.py
Storing absolute paths to a file thats apart of the installation isnt
good practice.
Possibilities for module import:
- Select the name of the module only. "contour" which is imported from
freestyle/style_modules
- name the package as a string "freestyle.style_modules.contour", use a
script to popup a menu and list these module so you dont have to lookup
the path externally to find the module name.
https://codereview.appspot.com/7416049/
More information about the Bf-codereview
mailing list