[Bf-codereview] Improved DDS Texture Support (issue 6188090)

[mogurijin at gmail.com]

https://codereview.appspot.com/6188090/diff/1/source/blender/gpu/intern/gpu_draw.c
File source/blender/gpu/intern/gpu_draw.c (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/gpu/intern/gpu_draw.c#newcode630
source/blender/gpu/intern/gpu_draw.c:630: int oldh= recth;
On 2012/06/28 09:52:25, ideasman42 wrote:
> these arn't used

Removed these.

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/allocimbuf.c
File source/blender/imbuf/intern/allocimbuf.c (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/allocimbuf.c#newcode166
source/blender/imbuf/intern/allocimbuf.c:166: free(ibuf->dds_data.data);
On 2012/06/28 09:52:25, ideasman42 wrote:
> shouldn't this use MEM_freeN() ? *(allocations too...)

dds_data.data is allocated by the DDS library that we're using (part of
Nvidia Texture Tools). Since NTT doesn't use MEM_mallocN() should we
still use MEM_freeN()?

https://codereview.appspot.com/6188090/diff/1/source/gameengine/Ketsji/BL_Texture.cpp
File source/gameengine/Ketsji/BL_Texture.cpp (right):

https://codereview.appspot.com/6188090/diff/1/source/gameengine/Ketsji/BL_Texture.cpp#newcode194
source/gameengine/Ketsji/BL_Texture.cpp:194: void
BL_Texture::InitGLCompressedTex(ImBuf* ibuf, bool mipmap)
On 2012/06/28 09:52:25, ideasman42 wrote:
> should cross reference - GPU_create_gl_tex_compressed(), if copied
code cant be
> shared

I've put as much shared code as I can into a bf_gpu function that both
now call.

https://codereview.appspot.com/6188090/