[Bf-codereview] Improved DDS Texture Support (issue 6188090)

[ideasman42 at gmail.com]

https://codereview.appspot.com/6188090/diff/1/source/blender/gpu/intern/gpu_draw.c
File source/blender/gpu/intern/gpu_draw.c (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/gpu/intern/gpu_draw.c#newcode630
source/blender/gpu/intern/gpu_draw.c:630: int oldh= recth;
these arn't used

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/allocimbuf.c
File source/blender/imbuf/intern/allocimbuf.c (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/allocimbuf.c#newcode166
source/blender/imbuf/intern/allocimbuf.c:166: free(ibuf->dds_data.data);
shouldn't this use MEM_freeN() ? *(allocations too...)

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/dds/DirectDrawSurface.cpp
File source/blender/imbuf/intern/dds/DirectDrawSurface.cpp (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/dds/DirectDrawSurface.cpp#newcode1138
source/blender/imbuf/intern/dds/DirectDrawSurface.cpp:1138: // It was
easier to copy this function from upstream than to resync.
picky - prefer C comments for descriptive text in C files.

https://codereview.appspot.com/6188090/diff/1/source/gameengine/Ketsji/BL_Texture.cpp
File source/gameengine/Ketsji/BL_Texture.cpp (right):

https://codereview.appspot.com/6188090/diff/1/source/gameengine/Ketsji/BL_Texture.cpp#newcode194
source/gameengine/Ketsji/BL_Texture.cpp:194: void
BL_Texture::InitGLCompressedTex(ImBuf* ibuf, bool mipmap)
should cross reference - GPU_create_gl_tex_compressed(), if copied code
cant be shared

https://codereview.appspot.com/6188090/