[Bf-codereview] Displace Node (issue 5528108)

[dfelinto at gmail.com]

It seems to be good now. If we have other reports in the future we know
where to tweak at least (and I'm glad the algorithm is working).

thanks Jeroen, I just committed.


On 2012/01/24 15:34:17, jbkkavt wrote:
> Dalai,

> please check. Using you example file I couldn't reproduce it anymore.
It is a
> rounding issue with the +0.5f isplaced pixel in uv coords, for image
sampling

> I tested with values from -100 to +100 for Xscale and Yscale.

> Regards,
> Jeroen


http://codereview.appspot.com/5528108/diff/1/source/blender/compositor/operations/COM_DisplaceOperation.cpp
> File source/blender/compositor/operations/COM_DisplaceOperation.cpp
(right):


http://codereview.appspot.com/5528108/diff/1/source/blender/compositor/operations/COM_DisplaceOperation.cpp#newcode130
> source/blender/compositor/operations/COM_DisplaceOperation.cpp:130:
> vectorInput.xmax = input->xmax + 1;
> Change +1 to +2 solves some rounding issues in determination of the uv
> coordinates


http://codereview.appspot.com/5528108/diff/1/source/blender/compositor/operations/COM_DisplaceOperation.cpp#newcode132
> source/blender/compositor/operations/COM_DisplaceOperation.cpp:132:
> vectorInput.ymax = input->ymax + 1;
> Change +1 to +2 solves some rounding issues in determination of the uv
> coordinates



http://codereview.appspot.com/5528108/