[Bf-codereview] Displace Node (issue 5528108)

jbkkavt at gmail.com jbkkavt at gmail.com
Tue Jan 24 16:34:18 CET 2012


Dalai,

please check. Using you example file I couldn't reproduce it anymore. It
is a rounding issue with the +0.5f isplaced pixel in uv coords, for
image sampling

I tested with values from -100 to +100 for Xscale and Yscale.

Regards,
Jeroen


http://codereview.appspot.com/5528108/diff/1/source/blender/compositor/operations/COM_DisplaceOperation.cpp
File source/blender/compositor/operations/COM_DisplaceOperation.cpp
(right):

http://codereview.appspot.com/5528108/diff/1/source/blender/compositor/operations/COM_DisplaceOperation.cpp#newcode130
source/blender/compositor/operations/COM_DisplaceOperation.cpp:130:
vectorInput.xmax = input->xmax + 1;
Change +1 to +2 solves some rounding issues in determination of the uv
coordinates

http://codereview.appspot.com/5528108/diff/1/source/blender/compositor/operations/COM_DisplaceOperation.cpp#newcode132
source/blender/compositor/operations/COM_DisplaceOperation.cpp:132:
vectorInput.ymax = input->ymax + 1;
Change +1 to +2 solves some rounding issues in determination of the uv
coordinates

http://codereview.appspot.com/5528108/


More information about the Bf-codereview mailing list