[Bf-codereview] Displace Node (issue 5528108)

[dfelinto at gmail.com]

If I change the render output to 200% I see the 'problem' happening
again in the quarters of the screen. (so as marking the boundary of some
tiles).

So what I may need to do is to have a initializeTileData for this
operation. I haven't defined that in any previous nodes so I need to
investigate if that's the problem.

On 2012/01/17 22:44:54, xavier.thomas.1980_gmail.com wrote:
> It might be a "Off by one" bug less noticeable in the non tiled
pipeline.

> 2012/1/16 <mailto:dfelinto at gmail.com>

> > Reviewers: http://bf-codereview_blender.org, jbkkavt,
> >
> > Description:
> > I had to make it into a Complex node to allow the readEWA to be
used.
> > (the other alternative is to expose readEWA to all node types when
dx
> > and dy are passed as parameter to read).
> >
> > The result is almost perfect (comparing to trunk). The only problem
is a
> > glitch in the middle:
> >
> > trunk: http://www.pasteall.org/pic/show.php?id=24506
> > tile: http://www.pasteall.org/pic/show.php?id=24505
> >
> > I'm yet to investigate the reason. It may be the readEWA code (which
is
> > also used by the MapUV node, but works fine there).
> >
> > Please review this at http://codereview.appspot.com/5528108/
> >
> > Affected files:
> >   source/blender/compositor/CMakeLists.txt
> >   source/blender/compositor/intern/COM_Converter.cpp
> >   source/blender/compositor/nodes/COM_DisplaceNode.cpp
> >   source/blender/compositor/nodes/COM_DisplaceNode.h
> >   source/blender/compositor/operations/COM_DisplaceOperation.cpp
> >   source/blender/compositor/operations/COM_DisplaceOperation.h
> >
> >
> > _______________________________________________
> > Bf-codereview mailing list
> > mailto:Bf-codereview at blender.org
> > http://lists.blender.org/mailman/listinfo/bf-codereview
> >



http://codereview.appspot.com/5528108/