[Bf-codereview] Camera tracking integration (issue 5285047)

[mierle at gmail.com]

I haven't looked through the reconstruction part yet.


http://codereview.appspot.com/5285047/diff/32002/extern/libmv/libmv-capi.cpp
File extern/libmv/libmv-capi.cpp (right):

http://codereview.appspot.com/5285047/diff/32002/extern/libmv/libmv-capi.cpp#newcode42
extern/libmv/libmv-capi.cpp:42:
Nitpick: What's the reason for the blank line here?

http://codereview.appspot.com/5285047/diff/32002/extern/libmv/libmv-capi.cpp#newcode64
extern/libmv/libmv-capi.cpp:64: typedef struct libmv_RegionTracker {
Consider documenting why these three objects are glued in here. Also
consider documenting who owns the pointers in the struct.

Why not use a destructor?

http://codereview.appspot.com/5285047/diff/32002/extern/libmv/libmv-capi.cpp#newcode87
extern/libmv/libmv-capi.cpp:87: void libmv_initLogging(const char
*argv0)
Thanks for keeping this in place.

http://codereview.appspot.com/5285047/diff/32002/extern/libmv/libmv-capi.cpp#newcode94
extern/libmv/libmv-capi.cpp:94: V3D::optimizerVerbosenessLevel = 0;
I can't wait until we can zap this guy.

http://codereview.appspot.com/5285047/