[Bf-codereview] Camera tracking integration (issue 5285047)

[brechtvanlommel at gmail.com]

Reviewed RNA changes, mostly just naming/description comments.


http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/object.c
File source/blender/blenkernel/intern/object.c (right):

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/object.c#newcode2207
source/blender/blenkernel/intern/object.c:2207: if(ob->partype &
PARSLOW) {
Also this code should not be duplicated I think, better make this a
common function.

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_movieclip.c
File source/blender/makesrna/intern/rna_movieclip.c (right):

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_movieclip.c#newcode174
source/blender/makesrna/intern/rna_movieclip.c:174:
RNA_def_struct_ui_text(srna, "Movie Clip User", "Parameters defining how
an MovieClip datablock is used by another datablock");
an MovieClip => a MovieClip

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_movieclip.c#newcode180
source/blender/makesrna/intern/rna_movieclip.c:180:
RNA_def_property_ui_text(prop, "Current Frame", "Get frame number user
is points to in clip");
Description is unclear

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_nodetree.c
File source/blender/makesrna/intern/rna_nodetree.c (right):

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_nodetree.c#newcode2451
source/blender/makesrna/intern/rna_nodetree.c:2451:
RNA_def_property_ui_text(prop, "Filter", "Method to use to filter
rotation");
rotation => stabilization?

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_nodetree.c#newcode2474
source/blender/makesrna/intern/rna_nodetree.c:2474:
RNA_def_property_ui_text(prop, "Distortion", "Distoriton to use to
filter image");
Distorition => Distortion

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_nodetree.c#newcode2491
source/blender/makesrna/intern/rna_nodetree.c:2491:
RNA_def_property_ui_text(prop, "Filter", "Method to use to filter
rotation");
rotation => transform

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_nodetree_types.h
File source/blender/makesrna/intern/rna_nodetree_types.h (right):

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_nodetree_types.h#newcode124
source/blender/makesrna/intern/rna_nodetree_types.h:124: DefNode(
CompositorNode, CMP_NODE_STABILIZE2D,    def_cmp_stabilize2d,
"STABILIZE2D",    Stabilize,        "Stabelize 2D",      ""
)
Stabelize => Stabilize

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_scene.c
File source/blender/makesrna/intern/rna_scene.c (right):

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_scene.c#newcode3749
source/blender/makesrna/intern/rna_scene.c:3749: prop=
RNA_def_property(srna, "clip", PROP_POINTER, PROP_NONE);
Rename to active_clip perhaps?

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_space.c
File source/blender/makesrna/intern/rna_space.c (right):

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_space.c#newcode856
source/blender/makesrna/intern/rna_space.c:856: static BGpic
*rna_BackgroundImage_add(View3D *v3d)
Please deduplicate this code with background_image_add, adding e.g.
ED_view3D_background_image_add()

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_space.c#newcode1565
source/blender/makesrna/intern/rna_space.c:1565:
RNA_def_property_ui_text(prop, "Show Camera Path", "Show reconstructed
path of ameraip");
ameraip => camera

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c
File source/blender/makesrna/intern/rna_tracking.c (right):

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode240
source/blender/makesrna/intern/rna_tracking.c:240:
{TRACKING_CLEAN_SELECT, "SELECT", 0, "Select", "Select un-clean
tracks"},
un-clean => unclean

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode247
source/blender/makesrna/intern/rna_tracking.c:247:
RNA_def_struct_ui_text(srna, "Movie tracking settings", "Match-moving
tracking settings");
Match-moving tracking settings => Match moving settings

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode253
source/blender/makesrna/intern/rna_tracking.c:253:
RNA_def_property_ui_text(prop, "tracker", "Tracking algorithm to use");
tracker => Tracker

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode259
source/blender/makesrna/intern/rna_tracking.c:259:
RNA_def_property_ui_text(prop, "Speed", "Speed to make tracking with");
This option is confusing to me, is it a quality setting? An option like
"Realtime" seems to imply it will track in realtime, but that would make
tracking give different quality results on different  runs/computers?

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode273
source/blender/makesrna/intern/rna_tracking.c:273:
RNA_def_property_ui_text(prop, "Adjust Frames", "Automatically re-adjust
marker position using position on each N frames. 0 means only keyframed
position is sued");
sued => used

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode315
source/blender/makesrna/intern/rna_tracking.c:315:
RNA_def_property_ui_text(prop, "Tracked Frames", "Affect on tracks which
are tracked less than specified amount of frames");
Affect => Effect, less than => less than the

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode322
source/blender/makesrna/intern/rna_tracking.c:322:
RNA_def_property_ui_text(prop, "Reprojection Error", "Affect on tracks
with have got larger reprojection error");
Affect => Effect, with have got => which have a

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode356
source/blender/makesrna/intern/rna_tracking.c:356:
RNA_def_property_ui_text(prop, "Focal Length", "Camera's focal length in
pixels");
Leave out "in pixels"

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode378
source/blender/makesrna/intern/rna_tracking.c:378:
RNA_def_property_ui_text(prop, "K1", "");
Add in description that this is a radial distortion parameter? Same for
next two properties.

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode411
source/blender/makesrna/intern/rna_tracking.c:411: prop=
RNA_def_property(srna, "pos", PROP_FLOAT, PROP_TRANSLATION);
These properties are typically called "co".

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode459
source/blender/makesrna/intern/rna_tracking.c:459:
RNA_def_property_ui_text(prop, "Pattern Min", "Left-bottom corner of
pattern area in unified coordinates relative to marker position");
unified => normalized?

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode530
source/blender/makesrna/intern/rna_tracking.c:530: prop=
RNA_def_property(srna, "hidden", PROP_BOOLEAN, PROP_NONE);
"hidden" => "hide" (convention)

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode536
source/blender/makesrna/intern/rna_tracking.c:536: prop=
RNA_def_property(srna, "locked", PROP_BOOLEAN, PROP_NONE);
"locked" => "lock" (convention)

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_tracking.c#newcode681
source/blender/makesrna/intern/rna_tracking.c:681:
RNA_def_property_ui_text(prop, "Reconstructed", "Is tracking data
contsains valid reconstruction information");
contsains => contains

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_ui_api.c
File source/blender/makesrna/intern/rna_ui_api.c (right):

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_ui_api.c#newcode403
source/blender/makesrna/intern/rna_ui_api.c:403:
RNA_def_function_ui_description(func, "Item(s). User interface for
selecting movie clips and their source paths.");
Descriptions should not end with "." for these functions

http://codereview.appspot.com/5285047/diff/26003/source/blender/makesrna/intern/rna_ui_api.c#newcode413
source/blender/makesrna/intern/rna_ui_api.c:413:
RNA_def_function_ui_description(func, "Item. A movie-marker widget to
control which depends on frame number.");
Don't understand this sentence

http://codereview.appspot.com/5285047/