[Bf-codereview] Camera sensor size (issue 5274047)

ideasman42 at gmail.com ideasman42 at gmail.com
Thu Oct 20 23:45:13 CEST 2011


Clarified comment about UV-project modifier.


http://codereview.appspot.com/5274047/diff/4001/source/blender/modifiers/intern/MOD_uvproject.c
File source/blender/modifiers/intern/MOD_uvproject.c (right):

http://codereview.appspot.com/5274047/diff/4001/source/blender/modifiers/intern/MOD_uvproject.c#newcode171
source/blender/modifiers/intern/MOD_uvproject.c:171: sensor_x=
camera->sensor_x;
On 2011/10/20 16:04:50, nazgul wrote:
> I'm not sure what "referenced from the object" means.

Each projector checks if its a camera type, when it is its sensor size
should be used, else if projecting from an empty - or any non camera -
the default (32) should be used.

Or put differently, the UV project modifier should not depend or act any
differently based on the scenes camera.

The camera 'cam's sensor size should be used (lines below).
----
if(projectors[i].ob->type == OB_CAMERA) {
     cam = (Camera *)projectors[i].ob->data;

http://codereview.appspot.com/5274047/


More information about the Bf-codereview mailing list