[Bf-codereview] Camera tracking integration (issue 5285047)

[g.ulairi at gmail.com]

Corrected (i hope) all current issues. New patchset would be sent here
soon.

The only thing i'm not sure about -- using names Track/Tracker/Tracking
instead of Movie Clip/
Reconstruction/Track/Solver.

"Track" is a set of merkers which point the same feature on the image.
"Tracker" is a sub-program, which tracks marker across image sequence to
make it points the same feature.
"Tracking" is more like a process when you're making marker be followed
feature.
"Solver" is a sub-program, which solves motion of camera using tracks
user created during "tracking".
"Reconstruction" is more like filling 3d scene with models of objects
from real world.

So it's just different things. I'm not sure about only one case -- using
reconstruction in 3d viewport display settings, it's not actually
reconstruction, more like a result of solving.. Not sure Solution would
be nicer here.


http://codereview.appspot.com/5285047/diff/3001/release/scripts/startup/bl_ui/properties_object_constraint.py
File release/scripts/startup/bl_ui/properties_object_constraint.py
(right):

http://codereview.appspot.com/5285047/diff/3001/release/scripts/startup/bl_ui/properties_object_constraint.py#newcode757
release/scripts/startup/bl_ui/properties_object_constraint.py:757:
layout.prop(con, "use_default_clip")
Yeah, you're right. Would correlate with scene settings better.

http://codereview.appspot.com/5285047/diff/3001/release/scripts/startup/bl_ui/properties_scene.py
File release/scripts/startup/bl_ui/properties_scene.py (right):

http://codereview.appspot.com/5285047/diff/3001/release/scripts/startup/bl_ui/properties_scene.py#newcode223
release/scripts/startup/bl_ui/properties_scene.py:223: bl_label = "Movie
Clip"
This active clip is needed to define relation between movie clip used as
main motion-tracking source and current scene. You can have several
clips solved, but normally scene can deal only with one of
tracked/solved clip. Other scenes can use other clips. This clip is used
as default "source" for camera solver and follow track constraints.
Normally you wouldn't want to change clip used by that constraints to
something else, only in case you've got witness cameras that settings in
costraints can make real sense..

http://codereview.appspot.com/5285047/diff/3001/release/scripts/startup/bl_ui/space_clip.py
File release/scripts/startup/bl_ui/space_clip.py (right):

http://codereview.appspot.com/5285047/diff/3001/release/scripts/startup/bl_ui/space_clip.py#newcode62
release/scripts/startup/bl_ui/space_clip.py:62: class
CLIP_PT_tools(Panel):
Yes, it's a rudiment which i thought i've dropped away. Dropped now for
sure.
Also dropped away panel with Clip-related operators when there's no
clip. Now toolbox seems to be really abandoned when there's no clip
opened..

http://codereview.appspot.com/5285047/diff/3001/release/scripts/startup/bl_ui/space_clip.py#newcode380
release/scripts/startup/bl_ui/space_clip.py:380: class
CLIP_PT_display(Panel):
Don't want this region be wider. Probably one column would be also
easier to find needed option. Most used options have got hotkey to be
toggled, so shouldn't be real issue with extra height of this panel.

http://codereview.appspot.com/5285047/diff/3001/release/scripts/startup/bl_ui/space_clip.py#newcode664
release/scripts/startup/bl_ui/space_clip.py:664: class
CLIP_MT_clip(Menu):
Indeed. Fixed in up-coming patchset.

http://codereview.appspot.com/5285047/diff/3001/release/scripts/startup/bl_ui/space_clip.py#newcode799
release/scripts/startup/bl_ui/space_clip.py:799:
layout.operator("clip.select_all", text="Inverse").action = 'INVERT'
Ok, changed to match 3d view select menu.

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/constraint.c
File source/blender/blenkernel/intern/constraint.c (right):

http://codereview.appspot.com/5285047/diff/3001/source/blender/blenkernel/intern/constraint.c#newcode4021
source/blender/blenkernel/intern/constraint.c:4021: /* calculate lens
and sensor size depends on object type */
Done, would be uploaded in new patchset soon. Probably name for function
isn't ideal..

http://codereview.appspot.com/5285047/diff/3001/source/blender/nodes/composite/nodes/node_composite_transform.c
File source/blender/nodes/composite/nodes/node_composite_transform.c
(right):

http://codereview.appspot.com/5285047/diff/3001/source/blender/nodes/composite/nodes/node_composite_transform.c#newcode39
source/blender/nodes/composite/nodes/node_composite_transform.c:39:
static bNodeSocketTemplate cmp_node_stabilize2d_in[]= {
Opps, better not only avoid using copy-pasteing, but also copying source
files :)

http://codereview.appspot.com/5285047/diff/3001/source/blender/nodes/composite/nodes/node_composite_transform.c#newcode43
source/blender/nodes/composite/nodes/node_composite_transform.c:43:
{	SOCK_FLOAT,		1,	"Degr",			0.0f, 0.0f, 0.0f, 0.0f, -10000.0f,
10000.0f},
Ok, renamed and marked as PROP_ANGLE

http://codereview.appspot.com/5285047/diff/3001/source/blender/nodes/composite/nodes/node_composite_transform.c#newcode75
source/blender/nodes/composite/nodes/node_composite_transform.c:75:
mul_serie_m4(mat, lmat, smat, cmat, rmat, icmat, NULL, NULL, NULL);
Not really. It was just stabilization parameters were calculated.
Probably scaling around image center before rotation would be better (so
scaled/rotated image would stay on center of "canvas"). It's a bit late
here, hope i didn't flipped order in translate-rotate-scale :)

http://codereview.appspot.com/5285047/