[Bf-codereview] New convenient get_sibling() function in Red-Black tree implementation (issue 5431064)
kokleine at googlemail.com
kokleine at googlemail.com
Thu Nov 24 15:57:51 CET 2011
Thank you Brecht! I've added the braces you recommended and will commit
my changes now. I will try to keep my changes bigger ;)
On 2011/11/24 13:01:30, brechtvl wrote:
> It looks ok to me, though usually such a small change would be done as
part of a
> bigger one, like adding the remove function.
http://codereview.appspot.com/5431064/diff/1/source/blender/blenlib/intern/DLRB_tree.c
> File source/blender/blenlib/intern/DLRB_tree.c (right):
http://codereview.appspot.com/5431064/diff/1/source/blender/blenlib/intern/DLRB_tree.c#newcode293
> source/blender/blenlib/intern/DLRB_tree.c:293: if (node &&
node->parent)
> I'd keep the { brackets here, some compilers warn about this.
http://codereview.appspot.com/5431064/
More information about the Bf-codereview
mailing list