[Bf-codereview] New convenient get_sibling() function in Red-Black tree implementation (issue 5431064)
brechtvanlommel at gmail.com
brechtvanlommel at gmail.com
Thu Nov 24 14:01:30 CET 2011
It looks ok to me, though usually such a small change would be done as
part of a bigger one, like adding the remove function.
http://codereview.appspot.com/5431064/diff/1/source/blender/blenlib/intern/DLRB_tree.c
File source/blender/blenlib/intern/DLRB_tree.c (right):
http://codereview.appspot.com/5431064/diff/1/source/blender/blenlib/intern/DLRB_tree.c#newcode293
source/blender/blenlib/intern/DLRB_tree.c:293: if (node && node->parent)
I'd keep the { brackets here, some compilers warn about this.
http://codereview.appspot.com/5431064/
More information about the Bf-codereview
mailing list