[Bf-codereview] Node changes from Particles Branch (issue4476050)
brechtvanlommel at gmail.com
brechtvanlommel at gmail.com
Mon May 9 13:15:24 CEST 2011
Latest changes look fine to me, except for this one thing.
http://codereview.appspot.com/4476050/diff/16001/source/blender/makesdna/DNA_node_types.h
File source/blender/makesdna/DNA_node_types.h (right):
http://codereview.appspot.com/4476050/diff/16001/source/blender/makesdna/DNA_node_types.h#newcode314
source/blender/makesdna/DNA_node_types.h:314: #define
SOCK_SUBTYPE_XYZ 12
I don't think there is much point in duplicating these from RNA, it's
just more work to keep them in sync this way. A comment in RNA_types.h
about these values being written to file should be ok (I should have
been more clear in my earlier comment).
http://codereview.appspot.com/4476050/
More information about the Bf-codereview
mailing list